meonkeys commented on PR #4715:
URL: https://github.com/apache/fineract/pull/4715#issuecomment-2920634144

   FYI, I asked in our `#fineract` Slack chat:
   
   > I almost feel bad for all this ceremony (github PR, JIRA ticket, full 
build, review) for such a trivial patch. So I'm wondering out loud here: Should 
I invoke the full ceremony for trivial patches? Or just commit directly to 
develop and push? The former feels most [strictly "by the 
book"](https://github.com/apache/fineract/#pull-requests)/safest/simplest/most 
consistent, the latter feels like [lazy 
consensus](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=91554327#FAQ(frequentlyaskedquestions)-WhatisourConsensusapproach?),
 but may be much more efficient (particularly for me, I like to commit small 
patches early and often) when the risk is particularly low (documentation-only 
changes). I'd of course still make sure all my changes aren't breaking the 
build. Anyway, just thought I'd raise this up the flagpole to see if anyone 
salutes.
   
   note that, in this patch, the groovy code changed only runs locally and is 
only used during the release process to simplify release email creation, and 
the rest is just in the asciidoc (which I built and visually checked)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to