meonkeys commented on code in PR #4715:
URL: https://github.com/apache/fineract/pull/4715#discussion_r2116173084


##########
buildSrc/src/main/groovy/org/apache/fineract/gradle/service/EmailService.groovy:
##########
@@ -76,7 +76,8 @@ class EmailService {
             msg.setSubject(params.subject, "UTF-8")
             msg.setText(params.message, "UTF-8");
 
-            Transport.send(msg);
+            //Transport.send(msg);

Review Comment:
   Anyway yeah, my intent here was simply to do the simplest, safest, and most 
useful change here so I could keep this release plugin limping along until we 
improve the release process itself. No disrespect to @vidakovic and @vorburger 
and whomever else poured love into this code over the years. Perhaps the 
options for releasing Apache code have improved since then?
   
   Today we can of course do better (e.g. just let GitHub help us release with 
far fewer clicks/steps).
   
   Also I am not proposing we change the release process today or even soon. 
Maybe in a quarter or two I'll propose changes, if/when there seems to be 
political will around that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to