meonkeys commented on code in PR #4715:
URL: https://github.com/apache/fineract/pull/4715#discussion_r2116162668
##########
buildSrc/src/main/groovy/org/apache/fineract/gradle/service/EmailService.groovy:
##########
@@ -76,7 +76,8 @@ class EmailService {
msg.setSubject(params.subject, "UTF-8")
msg.setText(params.message, "UTF-8");
- Transport.send(msg);
+ //Transport.send(msg);
Review Comment:
Great question. I did think about this for a bit. I should have been more
transparent about my intent. Allow me to explain.
For the 1.12.0 release process I used the groovy code to generate email
templates, but I wanted to edit the emails before sending so I disabled this
line, and intentionally left it so, figuring I'd be the one using and
[hopefully minimally] maintaining it for now.
The Fineract (release) plugin appears to be more or less unmaintained for
about 2 1/2 years now (save the semiautomated dependency updates). Looking at
the code and history, I assumed I was the only one that would be using it now
and in the near future. It also struck me how most everything it does is
primarily to work around antiquated Apache release process steps that are not
necessarily what we want for Fineract. Personally I think the Fineract release
plugin should be simply replaced by **a better release process**.
I think I'll add a comment there, and of course I welcome your feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
