adamsaghy commented on code in PR #4623:
URL: https://github.com/apache/fineract/pull/4623#discussion_r2259480836
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/AccountTransfersWritePlatformServiceImpl.java:
##########
@@ -270,6 +274,17 @@ private void undoTransactions(final
List<AccountTransferTransaction> accountTran
}
}
+ /**
+ * Returns an appropriate ExternalId based on configuration settings. If
auto-generation is enabled and the provided
+ * externalId is empty, generates a new one.
+ */
+ private ExternalId getExternalId(ExternalId externalId) {
Review Comment:
We dont need this... a simple IF-ELSE would be enought to either generate a
new or return empty...
No need for this, use `ExternalIdFactory`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
