adamsaghy commented on code in PR #4623:
URL: https://github.com/apache/fineract/pull/4623#discussion_r2259506579


##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java:
##########
@@ -3187,7 +3204,7 @@ private SavingsAccountTransaction 
handlePayChargeTransactions(SavingsAccountChar
     private void handleWaiverChargeTransactions(SavingsAccountCharge 
savingsAccountCharge, Money transactionAmount,
             boolean backdatedTxnsAllowedTill) {
         final SavingsAccountTransaction chargeTransaction = 
SavingsAccountTransaction.waiver(this, office(),
-                DateUtils.getBusinessLocalDate(), transactionAmount);
+                DateUtils.getBusinessLocalDate(), transactionAmount, null, 
ExternalId.empty());

Review Comment:
   Rewrite to get the external id as parameter



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to