adamsaghy commented on PR #4623: URL: https://github.com/apache/fineract/pull/4623#issuecomment-3163040391
@Lymah123 You need to rewrite the whole PR: - Use `ExternalIdFactory` in the services to generate an external id. It will check whether new should be generated or not. - Entities and DTOs should get the resolved ExternalId as parameter, no need any further logic in them! - Hardcoding `ExternalId.empty()` is usually considered incorrect! Use `ExternalIdFactory` instead to get the appropriate ExternalId object and value! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
