JohnAlva commented on code in PR #4886:
URL: https://github.com/apache/fineract/pull/4886#discussion_r2283060676
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsAccountInterestPostingServiceImpl.java:
##########
@@ -444,6 +548,26 @@ protected void recalculateDailyBalances(final Money
openingAccountBalance, final
accountTransaction.updateRunningBalance(runningBalance);
addTransactionToExisting(accountTransaction,
savingsAccountData);
+ isTransactionsModified = true;
+ } else if
(overdraftAmount.isNotEqualTo(Money.of(savingsAccountData.getCurrency(),
transaction.getOverdraftAmount()))
Review Comment:
Rewrote recalculateDailyBalances for clarity and consistency with the class
style. Business logic is unchanged; I just ordered the steps (effect
computation, running balance update, overdraft normalization, and
reverse+append flow) and used explicit variable names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
