wkigenyi commented on code in PR #5288:
URL: https://github.com/apache/fineract/pull/5288#discussion_r2675064577
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/serialization/LoanProductDataValidator.java:
##########
@@ -2797,6 +2797,9 @@ public void fixedLengthValidations(final String
transactionProcessingStrategyCod
private void validateLoanScheduleType(final String
transactionProcessingStrategyCode, final DataValidatorBuilder baseDataValidator,
final JsonElement element) {
final String loanScheduleType =
this.fromApiJsonHelper.extractStringNamed(LoanProductConstants.LOAN_SCHEDULE_TYPE,
element);
+ if (loanScheduleType == null) {
Review Comment:
The sole purpose of the PR is to check if the value **_null_** was provided
instead of leaving it out entirely or using **_undefined_** (remember it is not
a required field), and if this is the case the validate function does not
proceed (returns immediately). Is an integration test necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
