wkigenyi commented on code in PR #5288:
URL: https://github.com/apache/fineract/pull/5288#discussion_r2676041011
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/serialization/LoanProductDataValidator.java:
##########
@@ -2797,6 +2797,9 @@ public void fixedLengthValidations(final String
transactionProcessingStrategyCod
private void validateLoanScheduleType(final String
transactionProcessingStrategyCode, final DataValidatorBuilder baseDataValidator,
final JsonElement element) {
final String loanScheduleType =
this.fromApiJsonHelper.extractStringNamed(LoanProductConstants.LOAN_SCHEDULE_TYPE,
element);
+ if (loanScheduleType == null) {
Review Comment:
According to the validation and the API docs `loanScheduleType` is not among
the mandatory fields but it has a default value that is used in case it is not
specified when creating a loan product ie "CUMULATIVE". I have added some tests
to take care of this. I have also address a closely related issue where the
loanScheduleType has an invalid value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
