wkigenyi commented on code in PR #5288:
URL: https://github.com/apache/fineract/pull/5288#discussion_r2676269115
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/serialization/LoanProductDataValidator.java:
##########
@@ -2797,6 +2797,9 @@ public void fixedLengthValidations(final String
transactionProcessingStrategyCod
private void validateLoanScheduleType(final String
transactionProcessingStrategyCode, final DataValidatorBuilder baseDataValidator,
final JsonElement element) {
final String loanScheduleType =
this.fromApiJsonHelper.extractStringNamed(LoanProductConstants.LOAN_SCHEDULE_TYPE,
element);
+ if (loanScheduleType == null) {
Review Comment:
Front-end (javascript)developers sometimes think undefined and null are the
same thing, and if this field is provided as null from the front end (json), it
will make it as null to fineract in which case I think it should be treated as
if it were not provided at all (ignored, like it is in the PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
