Shivd131 opened a new pull request, #5353:
URL: https://github.com/apache/fineract/pull/5353

   ## [Description](https://issues.apache.org/jira/browse/FINERACT-2443)
   
   Currently, the reporting module lacks end-to-end integration tests that 
verify data integrity in the generated output. Existing tests primarily check 
for HTTP 200 OK statuses but do not validate that created client/loan data 
actually appears in the report body.
   
   **Changes:**
   - Added `ReportExecutionIntegrationTest.java`.
   - Implemented `verifyClientListingReportAndMetrics`:
     1. Creates a random Client via the API.
     2. Runs the "Client Listing" report in JSON/Table format.
     3. Runs the "Client Listing" report in CSV format.
     4. Asserts that the specific Client Name appears in both outputs.
   
   This ensures that the reporting engine is correctly querying and formatting 
data, paving the way for future refactoring of the reporting logic.
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [x] Write the commit message as per [our 
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
   - [x] Acknowledge that we will not review PRs that are not passing the build 
_("green")_ - it is your responsibility to get a proposed PR to pass the build, 
not primarily the project's maintainers.
   - [x] Create/update [unit or integration 
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the 
changes made.
   - [x] Follow our [coding 
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
   - [ ] Add required Swagger annotation and update API documentation at 
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with 
details of any API changes
   - [x] [This PR must not be a "code 
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
 Large changes can be made in a branch, with assistance. Ask for help on the 
[developer mailing list](https://fineract.apache.org/#contribute).
   
   Your assigned reviewer(s) will follow our [guidelines for code 
reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to