Shivd131 commented on PR #5353:
URL: https://github.com/apache/fineract/pull/5353#issuecomment-3773762906
@IOhacker Hey, thank you so much for the help and directions:). I have
updated my commits and PR to follow the conventions. Apologies for the remiss.
@adamsaghy Thanks for the feedback. I thought over it and have expanded the
test to cover a more encompassing scenario.
Here is the updated flow I have implemented:
**1. Client Listing**
* Tests simple entity retrieval (`m_client`).
* Verifies format negotiation (CSV, JSON outputs).
**2. Logic Verification (Active Loans - Details)**
* **Data Setup:** Creates Client → Loan Product → Loan Application.
* **Lifecycle Testing:** Explicitly moves the loan from **Approved** (Status
200) → **Disbursed** (Status 300).
* **Validation:** Runs the "Active Loans" report. This proves the engine
correctly handles:
* **SQL Joins:** (`m_loan` + `m_client` + `m_product_loan`)
* **State Filtering:** Verifying the engine respects the `WHERE
loan_status_id = 300` predicate (ensuring undisbursed loans don't appear).
* **Parameter Mapping:** Validating dynamic parameters like `R_officeId`
and `R_loanProductId`.
Also I would like to know if I have misunderstood your previous feedback. I
would appreciate knowing exactly which additional scenarios or logic you expect
to be tested so I can make this test robust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
