Shivd131 commented on PR #5353: URL: https://github.com/apache/fineract/pull/5353#issuecomment-3799746040
@adamsaghy I think I may be oversimplifying things on my end, so I’d like to clarify my understanding.. I’m still getting familiar with the overall system, and I want to be careful not to misinterpret what is meant by “cover all the reports.” At the moment, the test dynamically fetches the full list of installed reports and iterates through them to trigger the execution pipeline. The goal there was to verify that the observability instrumentation works in a global sense, even when specific report parameters are missing (hence the intentional try catch to ignore parameter/validation errors). When you say “cover all reports,” do you mean adding explicit data setup and assertions for each individual report (for example, General Ledger, Balance Sheet, etc.) to fully validate their execution? That would certainly be more comprehensive, but it would also increase the test runtime and overall complexity quite a bit. I would be glad if you could guide me by telling me the specifics about the requirement. Once I have that clarity, I’d be happy to refine or extend the tests accordingly, to what's actually needed, I want to avoid this PR ending up as a check for only a subset of cases, which is what you are currently pointing towards, so your elaboration would be very helpful :) Thanks for the help! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
