Monica-CodingWorld commented on PR #5362:
URL: https://github.com/apache/fineract/pull/5362#issuecomment-3977323893
Hi @adamsaghy,
The CI job Verify API Backward Compatibility is currently failing for this
PR. The main change I made was in a test where I mocked:
when(fromJsonHelper.extractLocalDateNamed(
eq(StandingInstructionApiConstants.validFromParamName),
eq(element)))
.thenReturn(LocalDate.of(2024, 1, 1));
Previously I had used LocalDate.now(ZoneId.systemDefault()), but replaced it
with a fixed date to avoid non-deterministic test behavior.
Apart from this and some import reordering, I did not make any API or
functional changes. Since the failure mentions breaking API changes /
configuration issues, I would appreciate guidance on what might be causing the
CI to fail.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
