AshharAhmadKhan commented on PR #5498: URL: https://github.com/apache/fineract/pull/5498#issuecomment-3985048675
@adamsaghy @IOhacker — thank you both for the patience and the restart. You were right to flag it, it wasn't just transient. I dug into the CI logs and found real compile errors introduced by the self-service removal: - `UserStepDef` was calling `create16()` - an OpenAPI-generated method that got renumbered to `create15()` after the self-service endpoints were removed - Several E2E test files (`EventCheckHelper`, `BatchApiStepDef`, `LoanStepDef`) had `Long`/`Integer` type mismatches in assertions, also caused by the generated API types changing after removal All fixed and included in the amended commit. Full local build passes, compile, unit tests across all modules, spotless. The only remaining expected failure is the OpenAPI backward compatibility check — intentional, since `isSelfServiceUser`, `selfServiceRoles`, and `clients` are removed from the Users API by design. Would a maintainer be able to update the baseline to unblock that check? Thanks again for the thorough review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
