AshharAhmadKhan commented on PR #5498: URL: https://github.com/apache/fineract/pull/5498#issuecomment-3992743836
@adamsaghy @IOhacker pushed a83bd1a with the remaining fixes. **SpotBugs** — removed dead `pathURL` local variable in `TenantAwareBasicAuthenticationFilter` left over from the self-service path check deletion. **Integer/Long mismatches** — three assertions broken by OpenAPI client regeneration after endpoint removal. `LoanStatus.getValue()` returns `Integer` but `getStatus().getId()` now returns `Long`, same pattern in `AdvancedPaymentAllocationLoanRepaymentScheduleTest.uc150` with `WHOLE_TERM`. `LoanStepDef.fetchValuesOfDisbursementDetails` was using raw `String.valueOf(BigDecimal)` which serialized as `1000.000000` instead of `1000.0`, replaced with `Utils.DoubleFormatter` matching the existing pattern in the same file. Only remaining failure is the OpenAPI backward compatibility check — intentional, needs maintainer baseline update for the removed `appUserClientMappings` fields. Could you restart CI when you get a chance? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
