tweise commented on a change in pull request #26:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/26#discussion_r815571835
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/BaseReconciler.java
##########
@@ -54,11 +65,8 @@ public boolean removeDeployment(FlinkDeployment flinkApp) {
Configuration effectiveConfig)
throws Exception;
- protected UpdateControl<FlinkDeployment> checkJobManagerDeployment(
- FlinkDeployment flinkApp,
- Context context,
- Configuration effectiveConfig,
- FlinkService flinkService) {
+ protected JobDeploymentStatus checkJobManagerDeployment(
+ FlinkDeployment flinkApp, Context context, Configuration
effectiveConfig) {
if (!jobManagerDeployments.contains(flinkApp.getMetadata().getUid())) {
Review comment:
Let's keep that out of this PR. However, I don't think we would want to
repeat port ready check on every reconciliation, even if deployment is cached.
I will think a bit more about it when implementing the terminal error state for
https://issues.apache.org/jira/browse/FLINK-26261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
