gyfora edited a comment on pull request #26:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/26#issuecomment-1053901452
Thank you @tweise and @wangyang0918 , I will address the comments in the
original commit.
I now pushed an optional refactor commit that restores the observe/reconcile
flow that we had before @tweise 's recent change while making it clearer and
including the jobmanager deployment validation.
I would like to hear your opinion about this. I think this makes the
reconciler simpler and the flow cleaner but this is an optional change if you
feel otherwise.
I think the key points are:
- Remove update control null checking in both session and job reconciler
- Observation of both deployment and job status is centralized in the
Observer
- Clear flow on when reconciliation should happen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
