gyfora commented on a change in pull request #26:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/26#discussion_r815587910
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentController.java
##########
@@ -86,16 +85,14 @@ public FlinkDeploymentController(
@Override
public DeleteControl cleanup(FlinkDeployment flinkApp, Context context) {
- LOG.info("Cleaning up application cluster {}",
flinkApp.getMetadata().getName());
- FlinkUtils.deleteCluster(flinkApp, kubernetesClient);
- IngressUtils.updateIngressRules(
- flinkApp,
- FlinkUtils.getEffectiveConfig(flinkApp,
defaultConfig.getFlinkConfig()),
- operatorNamespace,
- kubernetesClient,
- true);
+ LOG.info("Stopping cluster {}", flinkApp.getMetadata().getName());
getReconciler(flinkApp).removeDeployment(flinkApp);
Review comment:
good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
