tweise commented on a change in pull request #51:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/51#discussion_r824373450
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkOperatorConfiguration.java
##########
@@ -26,26 +26,33 @@
@Value
public class FlinkOperatorConfiguration {
- int reconcileIntervalInSec;
-
- int portCheckIntervalInSec;
-
- int savepointTriggerGracePeriodInSec;
+ int reconcileIntervalSeconds;
+ int progressCheckIntervalSeconds;
+ int restApiReadyDelaySeconds;
+ int savepointTriggerGracePeriodSeconds;
public static FlinkOperatorConfiguration fromConfiguration(Configuration
operatorConfig) {
- int reconcileIntervalInSec =
+ int reconcileIntervalSeconds =
operatorConfig.getInteger(
OperatorConfigOptions.OPERATOR_RECONCILER_RESCHEDULE_INTERVAL_IN_SEC);
- int portCheckIntervalInSec =
+
+ int restApiReadyDelaySeconds =
Review comment:
Why would this affect session cluster? There is a delay between the port
becoming available and the actual rest server being ready which absent any
other reliable technique to check we have the (now configurable!) delay for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
