wangyang0918 commented on a change in pull request #51:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/51#discussion_r824388470
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkOperatorConfiguration.java
##########
@@ -26,26 +26,33 @@
@Value
public class FlinkOperatorConfiguration {
- int reconcileIntervalInSec;
-
- int portCheckIntervalInSec;
-
- int savepointTriggerGracePeriodInSec;
+ int reconcileIntervalSeconds;
+ int progressCheckIntervalSeconds;
+ int restApiReadyDelaySeconds;
+ int savepointTriggerGracePeriodSeconds;
public static FlinkOperatorConfiguration fromConfiguration(Configuration
operatorConfig) {
- int reconcileIntervalInSec =
+ int reconcileIntervalSeconds =
operatorConfig.getInteger(
OperatorConfigOptions.OPERATOR_RECONCILER_RESCHEDULE_INTERVAL_IN_SEC);
- int portCheckIntervalInSec =
+
+ int restApiReadyDelaySeconds =
Review comment:
For example, if something is wrong or very slow with the leader
election, `JobManagerDeploymentStatus` is `READY ` but the session cluster is
not ready for accepting job submission. What I mean is to update the
`JobManagerDeploymentStatus` the `READY` only when the flink cluster is
actually working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
