gyfora commented on a change in pull request #51:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/51#discussion_r824423169
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkOperatorConfiguration.java
##########
@@ -26,26 +26,33 @@
@Value
public class FlinkOperatorConfiguration {
- int reconcileIntervalInSec;
-
- int portCheckIntervalInSec;
-
- int savepointTriggerGracePeriodInSec;
+ int reconcileIntervalSeconds;
+ int progressCheckIntervalSeconds;
+ int restApiReadyDelaySeconds;
+ int savepointTriggerGracePeriodSeconds;
public static FlinkOperatorConfiguration fromConfiguration(Configuration
operatorConfig) {
- int reconcileIntervalInSec =
+ int reconcileIntervalSeconds =
operatorConfig.getInteger(
OperatorConfigOptions.OPERATOR_RECONCILER_RESCHEDULE_INTERVAL_IN_SEC);
- int portCheckIntervalInSec =
+
+ int restApiReadyDelaySeconds =
Review comment:
I agree, the current check is not very robust and works only in a very
specific scenario. Let's open a ticket to track this effort and see if we can
come up with something better :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
