gyfora commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r835768073
##########
File path: helm/flink-operator/templates/flink-operator.yaml
##########
@@ -191,3 +183,20 @@ data:
{{- index (.Values.flinkDefaultConfiguration) "log4j-console.properties" |
nindent 4 -}}
{{- end }}
{{- end }}
+---
+{{- if .Values.pvc.create }}
+apiVersion: v1
+kind: PersistentVolumeClaim
+metadata:
+ name: {{ .Values.pvc.name }}
+ namespace: {{ .Release.Namespace }}
+ labels:
+ {{- include "flink-operator.labels" . | nindent 4 }}
+spec:
+ accessModes:
+ - ReadWriteOnce
+ volumeMode: Filesystem
+ resources:
+ requests:
+ storage: {{ .Values.pvc.size }}
+{{- end }}
Review comment:
what does this do? how does this relate to the volume mount
(`flink-userlib`) that you have specified in the values yaml?
##########
File path: helm/flink-operator/values.yaml
##########
@@ -41,11 +41,23 @@ jobServiceAccount:
"helm.sh/resource-policy": keep
name: "flink"
-hostPath:
+volumeMounts: |-
+ - name: flink-userlib
+ mountPath: /opt/flink/userlib
+
+volumes: |-
+ - name: flink-userlib
+ hostPath:
+ path: /tmp/flink/userlib
+ type: DirectoryOrCreate
Review comment:
we could call these `operatorVolumes` and `operatorVolumeMounts` to be a
bit more specific. Later we need a more generic way to customize the operator
and we can get rid of this but it's out of scope now.
Also we should not use strings here and I think the use should be able to
specify them in proper yaml format:
```
operatorVolumeMounts:
- name: flink-userlib
mountPath: /opt/flink/userlib
operatorVolumes:
- name: flink-userlib
hostPath:
path: /tmp/flink/userlib
type: DirectoryOrCreate
```
You can then in the template use `toYaml` in the template. There should be
some other examples already
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
