Aitozi commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r835771568
##########
File path: helm/flink-operator/templates/flink-operator.yaml
##########
@@ -191,3 +183,20 @@ data:
{{- index (.Values.flinkDefaultConfiguration) "log4j-console.properties" |
nindent 4 -}}
{{- end }}
{{- end }}
+---
+{{- if .Values.pvc.create }}
+apiVersion: v1
+kind: PersistentVolumeClaim
+metadata:
+ name: {{ .Values.pvc.name }}
+ namespace: {{ .Release.Namespace }}
+ labels:
+ {{- include "flink-operator.labels" . | nindent 4 }}
+spec:
+ accessModes:
+ - ReadWriteOnce
+ volumeMode: Filesystem
+ resources:
+ requests:
+ storage: {{ .Values.pvc.size }}
+{{- end }}
Review comment:
This is meant to create the `flink-userlib` pvc. If user specify the pvc
mounts, then the flink-operator should be installed by `--set pvc.create=true`.
There seems no good way to align the pvc definition and the mounts.
Since the mounts is a complex structure and may not be convenient to specify
in the command line(From my use of helm, may be not right :), If user have to
change the volume mount name , the pvc name should be changed correspondingly.
##########
File path: helm/flink-operator/templates/flink-operator.yaml
##########
@@ -191,3 +183,20 @@ data:
{{- index (.Values.flinkDefaultConfiguration) "log4j-console.properties" |
nindent 4 -}}
{{- end }}
{{- end }}
+---
+{{- if .Values.pvc.create }}
+apiVersion: v1
+kind: PersistentVolumeClaim
+metadata:
+ name: {{ .Values.pvc.name }}
+ namespace: {{ .Release.Namespace }}
+ labels:
+ {{- include "flink-operator.labels" . | nindent 4 }}
+spec:
+ accessModes:
+ - ReadWriteOnce
+ volumeMode: Filesystem
+ resources:
+ requests:
+ storage: {{ .Values.pvc.size }}
+{{- end }}
Review comment:
Do you mean we do not have to in charge of the PVC creating when install
operator?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
