gyfora commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r835773306
##########
File path: helm/flink-operator/templates/flink-operator.yaml
##########
@@ -191,3 +183,20 @@ data:
{{- index (.Values.flinkDefaultConfiguration) "log4j-console.properties" |
nindent 4 -}}
{{- end }}
{{- end }}
+---
+{{- if .Values.pvc.create }}
+apiVersion: v1
+kind: PersistentVolumeClaim
+metadata:
+ name: {{ .Values.pvc.name }}
+ namespace: {{ .Release.Namespace }}
+ labels:
+ {{- include "flink-operator.labels" . | nindent 4 }}
+spec:
+ accessModes:
+ - ReadWriteOnce
+ volumeMode: Filesystem
+ resources:
+ requests:
+ storage: {{ .Values.pvc.size }}
+{{- end }}
Review comment:
I think we could provide an example in the docs but maybe it would be
easier to not bother with PV/PVC stuff, super complex and lot of options. Now
with the mount configs users can mount any pvc easily.
Let's provide a simple example in the docs that works on minikube instead :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
