chaokunyang commented on code in PR #2532:
URL: https://github.com/apache/fory/pull/2532#discussion_r2302738994


##########
ci/deploy.sh:
##########
@@ -88,8 +88,10 @@ build_pyfory() {
   elif [[ "$OSTYPE" == "msys" || "$OSTYPE" == "win32" ]]; then
 
     if [ -n "$GITHUB_REF_NAME" ]; then
-      # Strip leading 'v' if present
       version="${GITHUB_REF_NAME#v}"
+      version="${version//-alpha/a}"

Review Comment:
   Maybe like:
   ```bash
   parse_py_version() {
     local version="$1"
     if [ -z "$version" ]; then
       # Get the latest tag from the current Git repository
       version=$(git describe --tags --abbrev=0)
     fi
     # Check if the tag starts with 'v' and strip it
     if [[ $version == v* ]]; then
       version="${version:1}"
     fi
     version="${version//-alpha/a}"
     version="${version//-beta/b}"
     version="${version//-rc/rc}"
     echo "$version"
   }
   
   bump_py_version() {
     local version
     version=$(parse_py_version "$1")
     python "$ROOT/ci/release.py" bump_version -l python -version "$version"
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to