chaokunyang commented on code in PR #2532:
URL: https://github.com/apache/fory/pull/2532#discussion_r2302723645
##########
ci/deploy.sh:
##########
@@ -88,8 +88,10 @@ build_pyfory() {
elif [[ "$OSTYPE" == "msys" || "$OSTYPE" == "win32" ]]; then
if [ -n "$GITHUB_REF_NAME" ]; then
- # Strip leading 'v' if present
version="${GITHUB_REF_NAME#v}"
+ version="${version//-alpha/a}"
Review Comment:
How abotu refactor `bump_py_version` into two functions, one is
`get_py_version`, another is `bump_py_version`, which just invoke `python
"$ROOT/ci/release.py" bump_version -l python -version $(get_py_version)`, then
we can use `get_py_version` here
##########
ci/deploy.sh:
##########
@@ -88,8 +88,10 @@ build_pyfory() {
elif [[ "$OSTYPE" == "msys" || "$OSTYPE" == "win32" ]]; then
if [ -n "$GITHUB_REF_NAME" ]; then
- # Strip leading 'v' if present
version="${GITHUB_REF_NAME#v}"
+ version="${version//-alpha/a}"
Review Comment:
How about refactoring `bump_py_version` into two functions, one is
`get_py_version`, another is `bump_py_version`, which just invoke `python
"$ROOT/ci/release.py" bump_version -l python -version $(get_py_version)`, then
we can use `get_py_version` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
