chaokunyang commented on code in PR #2532:
URL: https://github.com/apache/fory/pull/2532#discussion_r2302716355
##########
ci/deploy.sh:
##########
@@ -85,6 +85,21 @@ build_pyfory() {
else
$PYTHON_CMD setup.py bdist_wheel --dist-dir="$ROOT/dist"
fi
+ elif [[ "$OSTYPE" == "msys" || "$OSTYPE" == "win32" ]]; then
+
+ if [ -n "$GITHUB_REF_NAME" ]; then
+ # Strip leading 'v' if present
+ version="${GITHUB_REF_NAME#v}"
+ echo "Using version from GITHUB_REF_NAME: $version"
+
+ # Windows tends to drop alpha/beta markers - force it through setup.cfg
Review Comment:
I compared the release yaml with v0.12.0. v0.12.0 didn't pass `tag` to
`ci/deploy.sh bump_py_version`.
`bump_py_version` strip `v` from tag.
```bash
bump_py_version() {
local version="$1"
if [ -z "$version" ]; then
# Get the latest tag from the current Git repository
version=$(git describe --tags --abbrev=0)
# Check if the tag starts with 'v' and strip it
if [[ $version == v* ]]; then
version="${version:1}"
fi
fi
python "$ROOT/ci/release.py" bump_version -l python -version "$version"
}
```
If you pass tag explicitly, yo uneed top update the script:
```bash
bump_py_version() {
local version="$1"
if [ -z "$version" ]; then
# Get the latest tag from the current Git repository
version=$(git describe --tags --abbrev=0)
fi
# Check if the tag starts with 'v' and strip it
if [[ $version == v* ]]; then
version="${version:1}"
fi
python "$ROOT/ci/release.py" bump_version -l python -version "$version"
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
