mchernyakov commented on code in PR #3021:
URL: https://github.com/apache/fory/pull/3021#discussion_r2620873313


##########
java/fory-core/src/main/java/org/apache/fory/type/Descriptor.java:
##########
@@ -89,6 +89,8 @@ public static void clearDescriptorCache() {
   private final Method writeMethod;
   private ForyField foryField;
   private boolean nullable;
+  // trackingRef should only be true if explicitly set to true via 
@ForyField(ref=true)
+  // If no annotation or ref not specified, trackingRef stays false and 
type-based tracking applies
   private boolean trackingRef;

Review Comment:
   @chaokunyang addressed in 
https://github.com/apache/fory/pull/3021/commits/27e3280f715955f0ce60137affe7cab1ac80dad7
 
   
   and there is still question in 
https://github.com/apache/fory/pull/3021#discussion_r2617530972 
   
   pls check 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to