PragmaTwice commented on code in PR #1326:
URL: https://github.com/apache/incubator-fury/pull/1326#discussion_r1447360647
##########
src/fury/row/row.cc:
##########
@@ -237,8 +237,8 @@ int *ArrayData::GetDimensions(ArrayData &array, int
num_dims) {
// use deep-first search to search to numDimensions-1 layer to get
dimensions.
int depth = 0;
auto dimensions = new int[num_dims];
- int start_from_lefts[num_dims];
- ArrayData *arrs[num_dims]; // root to current node
+ int *start_from_lefts = new int[num_dims];
+ ArrayData **arrs = new ArrayData *[num_dims]; // root to current node
Review Comment:
If you want to workaround VLA, you can use std::unique_ptr for this purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
