LiangliangSui commented on code in PR #1326:
URL: https://github.com/apache/incubator-fury/pull/1326#discussion_r1447374452
##########
src/fury/thirdparty/MurmurHash3.cc:
##########
@@ -14,14 +14,22 @@
// Microsoft Visual Studio
+inline uint32_t rotl32(uint32_t x, int8_t r) {
+ return (x << r) | (x >> (32 - r));
+}
+
+inline uint64_t rotl64(uint64_t x, int8_t r) {
+ return (x << r) | (x >> (64 - r));
+}
+
#if defined(_MSC_VER)
#define FORCE_INLINE __forceinline
#include <cstdint>
-#define ROTL32(x, y) _rotl(x, y)
-#define ROTL64(x, y) _rotl64(x, y)
+#define ROTL32(x, y) rotl32(x, y)
+#define ROTL64(x, y) rotl64(x, y)
Review Comment:
Sorry, a missing header file caused a compilation error. I will modify it
back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
