LiangliangSui commented on code in PR #1326: URL: https://github.com/apache/incubator-fury/pull/1326#discussion_r1447375843
########## src/fury/meta/preprocessor.h: ########## @@ -25,8 +25,15 @@ // passed to the macros are fully expanded before they are concatenated. #define FURY_PP_CONCAT(a, b) FURY_PP_CONCAT_IMPL(a, b) +#ifdef _WIN32 +#define EXTEND(...) __VA_ARGS__ +#define FURY_PP_NARG_IMPL(...) EXTEND(FURY_PP_NARG_CALC(__VA_ARGS__)) +#define FURY_PP_NARG(...) \ + EXTEND(FURY_PP_NARG_IMPL(__VA_ARGS__, FURY_PP_NARG_REV())) +#else Review Comment: Because msvc will not expand the macro and will only pass it in as a parameter, this will lead to many syntax errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
