This is an automated email from the ASF dual-hosted git repository.
suiliangliang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/fury.git
The following commit(s) were added to refs/heads/main by this push:
new d450d7d7 fix(doc): codestyle version in python (#1706)
d450d7d7 is described below
commit d450d7d7e83908940cf84ee081078c6c40a1fa89
Author: PAN <[email protected]>
AuthorDate: Thu Jun 27 16:08:47 2024 +0800
fix(doc): codestyle version in python (#1706)
<!--
**Thanks for contributing to Fury.**
**If this is your first time opening a PR on fury, you can refer to
[CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md).**
Contribution Checklist
- The **Apache Fury (incubating)** community has restrictions on the
naming of pr titles. You can also find instructions in
[CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md).
- Fury has a strong focus on performance. If the PR you submit will have
an impact on performance, please benchmark it first and provide the
benchmark result here.
-->
## What does this PR do?
In fact, in Python's code style, here's the hint
```bash
pip install black==22.1.0 flake8==3.9.1 flake8-quotes flake8-bugbear
```
But there is no version of click
black actually depends on click, by default, our click is the latest, so
there is a problem of version inconsistency, and then the developer may
not know what version is needed, and may upgrade black. Unfortunately,
the ci/cd monitoring results are not the same for different versions of
black
I think it's the right thing to do to avoid ambiguity
```bash
pip install black==22.1.0 flake8==3.9.1 flake8-quotes flake8-bugbear
click==8.0.2
```
<!-- Describe the purpose of this PR. -->
## Related issues
https://github.com/apache/fury/blob/main/CONTRIBUTING.md
<!--
Is there any related issue? Please attach here.
- #xxxx0
- #xxxx1
- #xxxx2
-->
## Does this PR introduce any user-facing change?
<!--
If any user-facing interface changes, please [open an
issue](https://github.com/apache/fury/issues/new/choose) describing the
need to do so and update the document if necessary.
-->
- [ ] Does this PR introduce any public API change?
- [ ] Does this PR introduce any binary protocol compatibility change?
## Benchmark
<!--
When the PR has an impact on performance (if you don't know whether the
PR will have an impact on performance, you can submit the PR first, and
if it will have impact on performance, the code reviewer will explain
it), be sure to attach a benchmark data here.
-->
---
CONTRIBUTING.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 18f13371..152747ea 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -96,7 +96,7 @@ mvn checkstyle:check
```bash
cd python
# install dependencies fro styling
-pip install black==22.1.0 flake8==3.9.1 flake8-quotes flake8-bugbear
+pip install black==22.1.0 flake8==3.9.1 flake8-quotes flake8-bugbear
click==8.0.2
# format python code
black pyfury
```
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
