yma11 commented on code in PR #3870:
URL: https://github.com/apache/incubator-gluten/pull/3870#discussion_r1521062380
##########
cpp/velox/compute/WholeStageResultIterator.cc:
##########
@@ -145,15 +145,31 @@ WholeStageResultIterator::WholeStageResultIterator(
const auto& lengths = scanInfo->lengths;
const auto& format = scanInfo->format;
const auto& partitionColumns = scanInfo->partitionColumns;
+ const auto& metadataColumns = scanInfo->metadataColumns;
std::vector<std::shared_ptr<velox::connector::ConnectorSplit>>
connectorSplits;
connectorSplits.reserve(paths.size());
for (int idx = 0; idx < paths.size(); idx++) {
auto partitionColumn = partitionColumns[idx];
+ auto metadataColumn = metadataColumns[idx];
std::unordered_map<std::string, std::optional<std::string>>
partitionKeys;
constructPartitionColumns(partitionKeys, partitionColumn);
+ const std::unordered_map<std::string, std::string>& customSplitInfo = {};
+ const std::shared_ptr<std::string>& extraFileInfo = {};
+ const std::unordered_map<std::string, std::string>& serdeParameters = {};
Review Comment:
Do you plan to fill these variables in late PR? if not, I think it's avoid
to create them but just use `{}` in the constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
