gaoyangxiaozhu commented on code in PR #3870:
URL: https://github.com/apache/incubator-gluten/pull/3870#discussion_r1521209340
##########
gluten-core/src/main/scala/io/glutenproject/execution/BasicScanExecTransformer.scala:
##########
@@ -37,12 +37,15 @@ import com.google.protobuf.StringValue
import scala.collection.JavaConverters._
trait BasicScanExecTransformer extends LeafTransformSupport with
BaseDataSource {
+ import org.apache.spark.sql.catalyst.util._
/** Returns the filters that can be pushed down to native file scan */
def filterExprs(): Seq[Expression]
def outputAttributes(): Seq[Attribute]
+ def getMetadataColumns(): Seq[AttributeReference]
Review Comment:
this is for compatible spark33 purpose which already defineds
`metadataColumns` fields
https://github.com/apache/spark/blob/e98872fb5d07d570e6d0516b49a5d2e58876d1a6/sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala#L208C2-L210C1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
