gaoyangxiaozhu commented on code in PR #3870:
URL: https://github.com/apache/incubator-gluten/pull/3870#discussion_r1521142100
##########
cpp/velox/substrait/SubstraitParser.cc:
##########
@@ -104,31 +104,41 @@ std::vector<TypePtr>
SubstraitParser::parseNamedStruct(const ::substrait::NamedS
return typeList;
}
-std::vector<bool> SubstraitParser::parsePartitionColumns(const
::substrait::NamedStruct& namedStruct) {
+void SubstraitParser::parsePartitionAndMetadataColumns(
+ const ::substrait::NamedStruct& namedStruct,
+ std::vector<bool>& isPartitionColumns,
+ std::vector<bool>& isMetadataColumns) {
const auto& columnsTypes = namedStruct.column_types();
- std::vector<bool> isPartitionColumns;
if (columnsTypes.size() == 0) {
- // Regard all columns as non-partitioned columns.
+ // Regard all columns as regular columns.
Review Comment:
for read node it should be true, but not sure for write node if
`namedStruct.names()` also is 0 size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
