PHILO-HE commented on PR #5242: URL: https://github.com/apache/incubator-gluten/pull/5242#issuecomment-2033493414
> > Hi @sujithjay, we are removing presto scalar function registry in Gluten to fix conflict issues, see #5202. So could you register this presto function for sparksql in velox code? Generally, it just requires to include the corresponding header, then register it with a name aligned with Spark. > > Hi @PHILO-HE, please review the latest commit ([40747a6](https://github.com/apache/incubator-gluten/commit/40747a67638b7d7257b1549538c3da43cf0c8889)). Is this what you meant? Let me know if I am missing something. Thank you. @sujithjay, let me clarify a bit. I meant we need to change some Velox code, i.e., add this presto function into sparksql's registry (register it with "unbase64" name). Here is an example: https://github.com/facebookincubator/velox/pull/9215/files After that, Gluten will not need mapping "unbase64" to presto function name. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
