supermem613 commented on code in PR #5242:
URL: https://github.com/apache/incubator-gluten/pull/5242#discussion_r1559509415
##########
gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala:
##########
@@ -144,6 +144,7 @@ class VeloxTestSettings extends BackendTestSettings {
enableSuite[GlutenRegexpExpressionsSuite]
enableSuite[GlutenSortOrderExpressionsSuite]
enableSuite[GlutenStringExpressionsSuite]
+ .exclude("base64/unbase64 for string")
Review Comment:
@fyp711 , @sujithjay , @PHILO-HE, note that there are a few failure mode
behavior differences between velox and spark, all boiling down to the java
implementation of base64 decoding, so it is a bit more than just returning null
vs. exception on non-multiples of 4. Some examples in Spark, gleaned from
looking at Java sources:
* Extraneous padding is ignored. For example, "YQ=====" decodes to "a"
* Missing padding is ignored in some cases. For example, "aA" is decoded to
"h"
* Invalid characters in some cases are ignored. For example, "@@dmVsb3g="
decodes to "velox".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
