sujithjay commented on code in PR #5242:
URL: https://github.com/apache/incubator-gluten/pull/5242#discussion_r1553958594
##########
gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala:
##########
@@ -144,6 +144,7 @@ class VeloxTestSettings extends BackendTestSettings {
enableSuite[GlutenRegexpExpressionsSuite]
enableSuite[GlutenSortOrderExpressionsSuite]
enableSuite[GlutenStringExpressionsSuite]
+ .exclude("base64/unbase64 for string")
Review Comment:
@PHILO-HE @fyp711
Comparing the implementation in Velox with the `unbase64` implementation in
Spark, there are NO differences in implementation. The handling of the case
mentioned above by @fyp711 (when the length of the passed string is not a
multiple of 4 if padding is present) is handled similarly in both Spark and
Velox (they both throw an invalid input exception).
1.
https://github.com/facebookincubator/velox/blob/1deb0368b222e1074d23ed3204762ad1940afecc/velox/common/encode/Base64.cpp#L342-L346
2.
https://github.com/apache/spark/blob/6bd0ccf36dd23eb1887b73a898021a14baf1f2eb/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala#L2544-L2594
Let me know if I am missing something here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
