yma11 opened a new pull request, #5544: URL: https://github.com/apache/incubator-gluten/pull/5544
## What changes were proposed in this pull request? Fix `min_by`/`max_by` result mismatch. Take `max_by` for example, we need to keep intermediate result row like `<null, 11>` which will be compared with another result like `<5, 8>` and assure final result is `<null, 11>`. The `row_constructor_with_null` function doesn't need anymore since in Velox, all `groups` will be set `null` in `initializeNewGroupsInternal` and when processing an `null` raw input, it will skip updating the group thus the group keeps `null` or other original values. ## How was this patch tested? New UT added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
