yma11 commented on code in PR #5544:
URL: https://github.com/apache/incubator-gluten/pull/5544#discussion_r1582488826
##########
backends-velox/src/main/scala/org/apache/gluten/utils/VeloxIntermediateData.scala:
##########
@@ -159,7 +159,10 @@ object VeloxIntermediateData {
* row_constructor_with_null.
*/
def getRowConstructFuncName(aggFunc: AggregateFunction): String = aggFunc
match {
- case _: Average | _: Sum if aggFunc.dataType.isInstanceOf[DecimalType] =>
"row_constructor"
+ case _: Average | _: Sum if aggFunc.dataType.isInstanceOf[DecimalType] =>
+ "row_constructor"
+ case _: MaxMinBy =>
+ "row_constructor_with_all_null"
Review Comment:
I think by default, the upstream `row_constructor` doesn't set null value of
the struct, it just take the input children and wrap them as a row. These
issues are mainly caused by the additional projects we added, so it's
reasonable to handle it at our side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
