rui-mo commented on code in PR #5544:
URL: https://github.com/apache/incubator-gluten/pull/5544#discussion_r1582474605
##########
backends-velox/src/main/scala/org/apache/gluten/utils/VeloxIntermediateData.scala:
##########
@@ -159,7 +159,10 @@ object VeloxIntermediateData {
* row_constructor_with_null.
*/
def getRowConstructFuncName(aggFunc: AggregateFunction): String = aggFunc
match {
- case _: Average | _: Sum if aggFunc.dataType.isInstanceOf[DecimalType] =>
"row_constructor"
+ case _: Average | _: Sum if aggFunc.dataType.isInstanceOf[DecimalType] =>
+ "row_constructor"
+ case _: MaxMinBy =>
+ "row_constructor_with_all_null"
Review Comment:
@yma11 Is this change due to the semantics difference between Velox and
Spark? I wonder if it is possible to adjust the semantics of the implementation
in Velox and avoid introducing more hack in Gluten.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
