wForget commented on PR #6672: URL: https://github.com/apache/incubator-gluten/pull/6672#issuecomment-2271396098
@zhli1142015 Thanks for your work, as comment in https://github.com/apache/incubator-gluten/pull/4086#issuecomment-1871937485 suggested putting the validation into `SubstraitToVeloxPlanValidator`, I also tried it in the original PR, can you confirm which way is better? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
