zhli1142015 commented on PR #6672: URL: https://github.com/apache/incubator-gluten/pull/6672#issuecomment-2273102446
Yes. There are lots of change sinse your PR. `setSplitInfos` method is removed from the `SubstraitContext`. If we want to still follow that way, we need to bing it back or add separate property for this. And `getSplitInfos` is an expensive call, we should avoid to use it in validation. Instead we retrieve the first root path for validation here. And looks all file related validation is kept in the method `supportFileFormatRead`, file format, schema, etc. So we put the check here also. Last, `FakeParentPathFileSystem` doesn't work as expected in my local UT runs, mockfs:// is not supported by local file system. so I think a separate JNI wrapper API is needd for UT. Hee are the differences in my mind, please le me know is this makes sense to you, @PHILO-HE and @wForget , thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
