zhztheplayer commented on code in PR #6942:
URL: https://github.com/apache/incubator-gluten/pull/6942#discussion_r1724519402
##########
gluten-core/src/main/java/org/apache/gluten/vectorized/JniLibLoader.java:
##########
@@ -159,10 +160,16 @@ public static void unloadFromPath(String libPath) {
}
public void mapAndLoad(String unmappedLibName, boolean requireUnload) {
+ mapAndLoad(Optional.empty(), unmappedLibName, requireUnload);
+ }
+
+ public void mapAndLoad(
+ Optional<String> packagePath, String unmappedLibName, boolean
requireUnload) {
Review Comment:
Would suggest keeping one single `mapAndLoad` then doing the concatenation
in caller code.
Probably just rename the arg in previous `mapAndLoad` method from
`unmappedLibName` to `unmappedLibPath`?
##########
gluten-core/src/main/java/org/apache/gluten/vectorized/JniLibLoader.java:
##########
@@ -159,10 +160,16 @@ public static void unloadFromPath(String libPath) {
}
public void mapAndLoad(String unmappedLibName, boolean requireUnload) {
+ mapAndLoad(Optional.empty(), unmappedLibName, requireUnload);
+ }
+
+ public void mapAndLoad(
+ Optional<String> packagePath, String unmappedLibName, boolean
requireUnload) {
Review Comment:
Would suggest keeping one single `mapAndLoad` API then doing the
concatenation in caller code.
Probably just rename the arg in previous `mapAndLoad` method from
`unmappedLibName` to `unmappedLibPath`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
