PHILO-HE commented on PR #6942: URL: https://github.com/apache/incubator-gluten/pull/6942#issuecomment-2301349748
> > > Looking good though does this work with 3rd libs? > > > > > > With vpkg packaging, `3rd libs` seem to be no longer needed? Do we still need to handle `3rd libs` in this way? > > I personally never used that feature. @PHILO-HE Do you know some? It would sound great if we can remove, as for long term we will completely drop dynamic build support. Yes, third-party lib package will never be used if gluten is built by vcpkg. According to the feedback from some users, they are still using third-party package which is deployed together with gluten libs produced by dynamic linking. But we recommend all users to migrate to vcpkg build. I think, if not very necessary, let's do not change the code related to third-party libs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
