wForget commented on code in PR #6942:
URL: https://github.com/apache/incubator-gluten/pull/6942#discussion_r1724530915
##########
gluten-core/src/main/java/org/apache/gluten/vectorized/JniLibLoader.java:
##########
@@ -159,10 +160,16 @@ public static void unloadFromPath(String libPath) {
}
public void mapAndLoad(String unmappedLibName, boolean requireUnload) {
+ mapAndLoad(Optional.empty(), unmappedLibName, requireUnload);
+ }
+
+ public void mapAndLoad(
+ Optional<String> packagePath, String unmappedLibName, boolean
requireUnload) {
Review Comment:
Can the `System.mapLibraryName(unmappedLibName)` inside `mapAndLoad` method
be moved to the calling method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
