zhztheplayer commented on code in PR #7521:
URL: https://github.com/apache/incubator-gluten/pull/7521#discussion_r1798914269
##########
ep/build-velox/src/get_velox.sh:
##########
@@ -178,6 +179,8 @@ function apply_compilation_fixes {
cd ${velox_home}
echo "Applying patch to Velox source code..."
git apply modify_velox.patch
+ git apply gluten_patch/*patch
+ git add .
Review Comment:
Can we consider using [`git am`](https://git-scm.com/docs/git-am) rather
than `git apply` here to help a developer regenerate the patches after a manual
rebase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
