zhztheplayer commented on PR #7521: URL: https://github.com/apache/incubator-gluten/pull/7521#issuecomment-2412613853
> there are some sed -i command in our build-velox.sh. Let's take this opportunity to put them together as other commits. +1 > Let's switch to git submodule I heard some voices from other open source projects that git submodule has comparatively steep curve to work with. Perhaps we don't have to make the decision right now and lower the priority of doing that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
