FelixYBW commented on PR #7521: URL: https://github.com/apache/incubator-gluten/pull/7521#issuecomment-2412136228
There are several things to do before we switch to upstream: 1. Upstream our oap/velox commit to Velox as much as possible. there are still 11 commits now: https://github.com/facebookincubator/velox/compare/main...oap-project:velox:update. See if we can ping the author of those PRs. 2. We still need some where to easily track our changes, like the link above. `git apply` isn't good because the batch is hard to maintain. 3. Let's switch to git submodule 4. there are some `sed -i` command in our build-velox.sh. Let's take this opportunity to put them together as other commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
